Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer actions overflow menu #7123

Merged
merged 17 commits into from
Jun 13, 2023
Merged

Layer actions overflow menu #7123

merged 17 commits into from
Jun 13, 2023

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Jun 5, 2023 •
edited
Loading

Steps to test:

  • Create annotation and go to layer tab on the left sidebar
  • Checkout the layer actions in the overflow menu

Issues:

(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Jun 5, 2023
@dieknolle3333 dieknolle3333 marked this pull request as ready for review June 5, 2023 16:20
philippotto
philippotto requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! However, null menu items can occur at the moment, which needs to be fixed :) See my one comment.

Additionally, I have another idea. There are two buttons in the icon row which refer to the histogram. In my opinion, they should be moved into the histogram view (so one line below the current icon row). This might work with some CSS margins. Maybe you could give this a try? If it gets to fiddly, you can also leave it as is. I just thought that this might be a good time to change that. See screenshot:
image

frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/left-border-tabs/layer_settings_tab.tsx Outdated Show resolved Hide resolved
@philippotto
Copy link
Member

Hmm, unfortunately, the sidebar is kind of broken for me? I'm on Chrome / Linux if that matters:

image

Does it work for you currently?

@dieknolle3333
Copy link
Contributor Author

Hmm, unfortunately, the sidebar is kind of broken for me? I'm on Chrome / Linux if that matters:

image

Does it work for you currently?

No, it doesn't work yet. I just pushed my WIP code in order not to lose it. Should I do that differently next time?

philippotto
philippotto approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Ship it :shipit:

@dieknolle3333 dieknolle3333 merged commit 9c2b739 into master Jun 13, 2023
@dieknolle3333 dieknolle3333 deleted the layer-actions-overflow-menu branch June 13, 2023 09:23
@dieknolle3333
Copy link
Contributor Author

Nice, thank you :D

hotzenklotz added a commit that referenced this pull request Jun 14, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into red…
8e3a3e2 
…esign-right-sidebar

* 'master' of github.com:scalableminds/webknossos:
  Layer actions overflow menu (#7123)
  Unify DatasetPath and VaultPath, cleaner ChunkReader creation (#7134)
  Segment to Bucket Index for Volume Annotations (#7063)
  Reverse compression on sharded neuroglancer datasets (#7135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@dieknolle3333 dieknolle3333

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create overflow menu for layer actions in left sidbar
2 participants
@dieknolle3333 @philippotto