Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload of bounding box only skeleton annotations #6985

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fix upload of bounding box only skeleton annotations #6985

merged 3 commits into from
Apr 17, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Apr 17, 2023 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Upload skeleton annotation with trees -> should work as before ✔️
  • Upload skeleton annotation without trees, only bounding boxes -> should accept upload and create bounding boxes ✔️
  • Upload skeleton annotation without anything -> should not be accepted ✔️

Issues:

(Please delete unneeded items, merge only when none are left open)

@frcroth frcroth requested a review from fm3 April 17, 2023 12:30
@frcroth frcroth changed the title Fix upload of bounding box only skeletons Fix upload of bounding box only skeleton annotations Apr 17, 2023
@frcroth frcroth self-assigned this Apr 17, 2023
fm3
fm3 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet :] works for me

@frcroth frcroth merged commit 0c7385f into master Apr 17, 2023
@frcroth frcroth deleted the nmlonlybb2 branch April 17, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@frcroth frcroth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NML upload with no skeletons but bounding boxes should not be rejected
2 participants
@frcroth @fm3