Use new zip.js version to allow zip64 uploads #6939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool! Since you just looked into the topic: Any chance we could ditch the jszip library, too? It's currently used to let the user import a hybrid annotation as a zip into the skeleton tab via drag and drop. The code around it is a bit more complex, but maybe the interface didn't change much? If it's too much of a hassle, feel free to keep it as is :) |
|
@philippotto Good suggestion! Was fairly easy to replace :) |
philippotto
approved these changes
Mar 27, 2023
hotzenklotz
added a commit
that referenced
this pull request
Apr 3, 2023
…come-toast * 'master' of github.com:scalableminds/webknossos: Log all details on deleting annotation layer (#6950) fix typo Rename demo instance to wkorg instance (#6941) Add LOD mesh support for frontend (#6909) Fix layout of view mode switcher and move it (#6949) VaultPath no longer extends nio.Path (#6942) Release 23.04.0 (#6945) Use new zip.js version to allow zip64 uploads (#6939) Implement viewing sharded neuroglancer precomputed datasets (#6920) Reject dataset uploads if organization storage quota is exceeded (#6893) Refactor deprecated antd Dropdown menus (#6898)
hotzenklotz
added a commit
that referenced
this pull request
Apr 4, 2023
…wings * 'master' of github.com:scalableminds/webknossos: updates docs for docker installation (#6963) Fix misc stuff when viewing tasks/annotations of another user (#6957) Remove segment from list and add undo/redo for segments (#6944) Log all details on deleting annotation layer (#6950) fix typo Rename demo instance to wkorg instance (#6941) Add LOD mesh support for frontend (#6909) Fix layout of view mode switcher and move it (#6949) VaultPath no longer extends nio.Path (#6942) Release 23.04.0 (#6945) Use new zip.js version to allow zip64 uploads (#6939) Implement viewing sharded neuroglancer precomputed datasets (#6920) Reject dataset uploads if organization storage quota is exceeded (#6893) Refactor deprecated antd Dropdown menus (#6898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to upload the recent negative_float test dataset, getting the message that the zip file was invalid, even after re-zipping. I investigated and found out that the 4 year old repackaged version of zip.js we used doesn't support zip64 (which is used if the files > 4 GB are zipped). In the meantime, zip.js supports webpack and also supports zip64 which is why I decided to use the official version instead. Review ignoring white space changes.
URL of deployed dev instance (used for testing):
Steps to test:
(Please delete unneeded items, merge only when none are left open)