Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some login problems #6810

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Fix some login problems #6810

merged 4 commits into from
Feb 6, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Feb 3, 2023 •
edited
Loading

This PR fixes two problems:

  • after logging in, an error boundary UI briefly showed up, because the active organization wasn't set yet (but was enforced by the dashboard)
  • due to the above bug I noticed that there was apparently a hard refresh after logging in which I fixed now since it was unnecessary.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • log in from /auth/login and from the navbar (e.g., open a public dataset for that)
  • logging in should not show up an error message

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Feb 3, 2023
hotzenklotz
hotzenklotz approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Thanks.

What component caused the full page refresh?

@philippotto
Copy link
Member Author

What component caused the full page refresh?

See here: https://github.com/scalableminds/webknossos/blob/master/frontend/javascripts/router.tsx#L273
I think it's necessary so that the user can be redirected to webknossos.org after logging out (which doesn't live inside this repo).

@philippotto philippotto merged commit d91f148 into master Feb 6, 2023
@philippotto philippotto deleted the fix-login-problems branch February 6, 2023 08:30
hotzenklotz added a commit that referenced this pull request Feb 6, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into org…
b04de23 
…a_owner

* 'master' of github.com:scalableminds/webknossos:
  Fix saving allowed teams in dataset settings (#6817)
  Prevent Deactivaing Orga Owner (#6816)
  Fix some login problems (#6810)
hotzenklotz added a commit that referenced this pull request Feb 7, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into fix…
b1a2f0b 
…_editable_text_style

* 'master' of github.com:scalableminds/webknossos:
  Rewrite database tooling and support for postgres passwords (#6803)
  Fix saving allowed teams in dataset settings (#6817)
  Prevent Deactivaing Orga Owner (#6816)
  Fix some login problems (#6810)
philippotto added a commit that referenced this pull request Feb 7, 2023
@philippotto
Fix some login problems (#6810)
d876df9 
* ensure that active organization is set after logging in

* avoid unnecessary page refresh after logging in

* update changelog

* explain hard reload
philippotto added a commit that referenced this pull request Feb 7, 2023
@philippotto
Release 23.02.1 (#6827)
9de481c 
* Release 23.02.0

* Fix some login problems (#6810)

* ensure that active organization is set after logging in

* avoid unnecessary page refresh after logging in

* update changelog

* explain hard reload

* update changelogs

* remove redundant entries due to merge conflict

* remove redundant entries due to merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

Assignees

@philippotto philippotto

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @hotzenklotz