-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new sql interpolator in more DAOs, clean up #6723
Conversation
@normanrz Could you have a look at the changes in the SqlInterpolation file, and possibly check a few usages to see if I use this the way you intended it? @jstriebel agreed to look at the other changes :) It would also be appreciated if you could do some random testing. The fact that all SQL errors are logged and reported to slack makes me optimistic that we should find errors quickly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. A few notes:
- For INSERTs, you could use
SqlToken.tuple(...)
to supply the values instead of interpolating them separately into the query - Not sure whether boolean constants should be written in or passed in
- Please add tests for each new datatype that you added to
SqlValue
- We should think of more helper functions to make inserts, updates and upserts less verbose
- Since you migrated all the big DAOs, it should be quick to do the rest, no?
Thanks for your feedback!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all things that looked weird are already part of the follow-up points 👍 🚀
Props for adding tests! ❤️
.debugInfo
URL of deployed dev instance (used for testing):
Issues
TODO
Follow-up
Steps to test: