Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically open (and close) quick select settings when labeling in… #6706

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Automatically open (and close) quick select settings when labeling in… #6706

merged 2 commits into from
Dec 20, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Dec 19, 2022 •
edited
Loading

… preview mode. That way, bulk labelings with preview mode don't require constantly opening the settings manually.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • use quick select tool with and without preview mode and check usability of settings

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Dec 19, 2022
hotzenklotz
hotzenklotz approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick action in response to my feedback. PR LGTM

@philippotto philippotto merged commit df08e63 into master Dec 20, 2022
@philippotto philippotto deleted the auto-open-quick-select-settings branch December 20, 2022 08:57
hotzenklotz added a commit that referenced this pull request Dec 20, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into pri…
b3f37d2 
…cing

* 'master' of github.com:scalableminds/webknossos:
  Automatically open (and close) quick select settings when labeling in… (#6706)
  Add Terms of Service Acceptance Concept (#6632)
  Fix crash in publication page and add error boundaries (#6700)
  temporarily disable vx related polling (#6702)
  add protected and private modifiers to DAO hierarchy (#6698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

Assignees

@philippotto philippotto

Labels
enhancement frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @hotzenklotz