Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure used disk storage #6685

Merged
merged 24 commits into from
Jan 11, 2023
Merged

Measure used disk storage #6685

merged 24 commits into from
Jan 11, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Dec 7, 2022

webKnossos now measures the storage used by the datasets of the organizations.
New config options datastore.reportUsedStorage.enabled and webKnossos.fetchUsedStorage.interval.
Note that the organization is re-scanned regularly, but dataset upload + delete trigger a refresh of said dataset directly.
Datastores report that they have reportUsedStorage.enabled to webKnossos, which then stores that info in the postgres datastores table.
Load distribution strategy assumes that measuring a single organization isn’t that huge an operation (optimized for multi-orga setup).

Steps to test:

  • turn on storage reporting as described above
  • start up, after initial delay, the organization api request should include used storage
  • test with multiple organizations that the load distribution logic works

Issues:


@fm3 fm3 self-assigned this Dec 7, 2022
@fm3 fm3 marked this pull request as ready for review December 12, 2022 15:49
@fm3 fm3 requested a review from jstriebel December 13, 2022 10:27
@fm3 fm3 changed the title WIP: Measure used disk storage Measure used disk storage Dec 13, 2022
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications, LGTM 👍

@fm3
Copy link
Member Author

fm3 commented Jan 10, 2023

@philippotto could you have a quick look at the latest commit cd80b77 ? I adapted the front-end to use the new measured value

@philippotto
Copy link
Member

@philippotto could you have a quick look at the latest commit cd80b77 ? I adapted the front-end to use the new measured value

Looks good to me 👍

@fm3 fm3 merged commit 873cc6d into master Jan 11, 2023
@fm3 fm3 deleted the storage branch January 11, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate storage use
3 participants