Skip to content

Deduplicate bboxes when importing NML #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Nov 17, 2022

URL of deployed dev instance (used for testing):

Steps to test:

  • create an annotation
  • create a bbox
  • download the NML (use the dropdown menu in the toolbar)
  • import the NML with DnD
  • the bbox should not be duplicated

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Nov 17, 2022
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 👍

@philippotto philippotto enabled auto-merge (squash) November 21, 2022 14:48
@philippotto philippotto merged commit eb11816 into master Nov 21, 2022
@philippotto philippotto deleted the deduplicate-bboxes branch November 21, 2022 15:05
hotzenklotz added a commit that referenced this pull request Dec 6, 2022
…cing

* 'master' of github.com:scalableminds/webknossos: (23 commits)
  Guard against invalid-mag bucket volume save actions (#6660)
  Add OIDC authentication (#6534)
  Add second (non-admin) default user to "initial data" trigger (#6666)
  Fix and improve miscellaneous things in Folders tab (#6674)
  Improves mag and voxelSize inferral for remote datasets (#6670)
  Squashed commit of the following:
  Fix import of N5 datasets by adding n5 schema to frontend validation (#6668)
  Virtual Folder Structure for Datasets (#6591)
  Ability to recover from webGL context loss (#6663)
  Fix assertion that referenced teams cannot be deleted (#6664)
  fix task summary with pending jobs (#6662)
  Only allow taskTypeId as parameter in task creation (#6640)
  Release 22.12.0 (#6661)
  Create Annotation From View Mode: Keep Activated Mapping (#6647)
  Workaround to avoid false-positive version warning (#6656)
  Fix WK-lib download snippet (#6605)
  Use LZ4 with WASM for volume saving/undo/redo (#6652)
  Fix version number extraction when building docker image (#6655)
  Pass mapping name to precompute meshes (#6651)
  Deduplicate bboxes when importing NML (#6648)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When merging annotations, deduplicate bounding boxes
2 participants