Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include scale bar in screenshots #6644

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Nov 16, 2022

Was easier than thought :) The lines added only stem from me adding new lines between functions in the utils module.

These are automatic screenshots made using the webKnossos functionality:

l4_sample__3584_3584_1024__TDView
l4_sample__3584_3584_1024__PLANE_XY

URL of deployed dev instance (used for testing):

Steps to test:

  • Press Q or select "Screenshot" from the menu. The scale bar should be included in the screenshots if it was activated. The 3d view buttons should not be included.

Issues:


(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Nov 16, 2022
@daniel-wer
Copy link
Member Author

I did not find a workaround for the "blurry" lines of the scale bar. It seems to depend on the screen resolution and size of the viewports. Also happens without the transparent background or with z-index set 🤷 I don't think it's a blocker, but feel free to test yourself if you have any additional ideas :)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🕺 By the way, on my setup, there are no blurry lines in the screenshots :)

@daniel-wer
Copy link
Member Author

By the way, on my setup, there are no blurry lines in the screenshots :)

Interesting. I suspected the 200% scaling of my Hi-DPI screen to cause the blurry lines, but that's not the case. Instead, I noticed that the overlay did not work on Hi-DPI screens with a devicePixelRatio > 1. Was easy to fix and I added a note to the data canvas Hi-DPI issue to remove this workaround again if we ever complete said issue.

@bulldozer-boy bulldozer-boy bot merged commit 9c5480d into master Nov 17, 2022
@bulldozer-boy bulldozer-boy bot deleted the include-scale-bar-in-screenshots branch November 17, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale bar is not saved with the screenshot
2 participants