Skip to content

Fix precomputed mesh positions #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2022
Merged

Fix precomputed mesh positions #6588

merged 4 commits into from
Oct 25, 2022

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Oct 25, 2022 •
edited
Loading

by scaling the whole group instead of each chunk on its own. Fixing a regression introduced in #6552. See https://scm.slack.com/archives/C5AKLAV0B/p1666683368029709 for context.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Use a v3 meshfile and load a precomputed mesh consisting of multiple chunks. The meshes should appear at the correct position.

(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Oct 25, 2022
philippotto
philippotto approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't test. Can't do much (more) harm, though, I think :)

@bulldozer-boy bulldozer-boy bot merged commit 27966b9 into master Oct 25, 2022
@bulldozer-boy bulldozer-boy bot deleted the fix-mesh-positions branch October 25, 2022 10:05
@philippotto philippotto mentioned this pull request Oct 27, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

@normanrz normanrz Awaiting requested review from normanrz

Assignees

@daniel-wer daniel-wer

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-wer @philippotto