Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes workflow_yamlContent optional #6518

Merged
merged 2 commits into from
Sep 30, 2022
Merged

makes workflow_yamlContent optional #6518

merged 2 commits into from
Sep 30, 2022

Conversation

normanrz
Copy link
Member

Actually, the field workflow_yamlContent is optional. For example, when constructing the workflow in code (like in the tests).


@normanrz normanrz self-assigned this Sep 29, 2022
@normanrz normanrz requested a review from fm3 September 29, 2022 19:49
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was already optional in the schema – how did this work before, was there a default value when parsing from sql?

@normanrz
Copy link
Member Author

how did this work before

It didn't. I didn't test it with the vx tests yet.

@normanrz normanrz merged commit cddd970 into master Sep 30, 2022
@normanrz normanrz deleted the fix-vx-yaml branch September 30, 2022 07:04
leowe pushed a commit that referenced this pull request Sep 30, 2022
hotzenklotz added a commit that referenced this pull request Oct 13, 2022
…jects-created

* 'master' of github.com:scalableminds/webknossos: (337 commits)
  Fix docs for the annotation download file format (#6546)
  Added total runtime information to VX reports (#6543)
  fix VX report for completed + skipped tasks (#6540)
  Avoid allocating spire uint objects during apply agglomerate (#6532)
  Explore remote N5 datasets (#6520)
  Fix MeshChunk byteOffset (Long, not Int) (#6536)
  update browserslist (#6505)
  Support new Mesh File (v3) (#6491)
  makes workflow_yamlContent optional (#6518)
  Always return 404 for Failures in Zarr Streaming (#6515)
  Poll wk version to notify during upgrade (#6451)
  add script which extracts newest changelog and creates GH release for it (#6504)
  release 22.10.0 (#6500)
  voxel³ -> voxel (#6501)
  Allow task type summary to identify task type when creating tasks in bulk (#6486)
  Fix sql evolution 090 (defer not null constraint) (#6498)
  SQL schema cleanup (#6492)
  Fix validation of layer selection when trying to start globalization of floodfills (#6497)
  Add "shift + w" shortcut to cycle backwards through tools (#6493)
  Fix filtering for public datasets in dataset table (#6496)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants