-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make version history view paginated #6483
Conversation
@philippotto this issue became relevant again recently (a user reported data loss and we could not explore older annotation version as the update action log request did not complete in reasonable time). Do you think you have some capacity to adapt the front-end to use pagination? And if so, do you think the API with newestVersion and oldestVersion makes sense? Or would you prefer to send a limit and page number? The front-end should already know the newest possible version of the tracing, right? and the oldest should always be zero. This is not urgent, but if you have some time, maybe you could have a look :) |
I'm having a look :) @frcroth could you do the same for the SkeletonTracingController? I think it makes sense that both version routes use the pagination mechanism. |
The front-end is ready from my side. For easier testing I set the items per page parameter to The only thing missing is that the back-end also accepts the new parameters for skeleton tracings. |
Yes 500 seems reasonable. We can still tweak it again later if we find that with real-world annotations this is still slow |
@philippotto The route for skeleton tracing is implemented |
Thanks! @fm3 Would you like to test this PR? Maybe you could also review the frontend? In that case, I think it would be easiest to have a quick call where I guide you through it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me :) Thanks for guiding me through the code in person. Maybe you can investigate why the first two pages are fetched twice each
Found the bug! I had to change a |
URL of deployed dev instance (used for testing):
Steps to test:
Issues: