Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resolution parameter from requestRawCuboid #6479

Merged
merged 6 commits into from
Sep 20, 2022

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Sep 20, 2022

Issues:

Since this is an API change, I guess it needs some documentation?


(Please delete unneeded items, merge only when none are left open)

@frcroth frcroth requested a review from fm3 September 20, 2022 07:35
@frcroth frcroth self-assigned this Sep 20, 2022
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)
On API Documentation: the old, textual documentation at https://docs.webknossos.org/webknossos/rest_api.html includes only a subset of api endpoints that were at the time considered relevant to users.
Now we encourage using the python library, which uses @ApiParam annotations, which are composed into a swagger.json file as annotation.
So I’d say no further changes are required. However, I’d ask to add a changelog entry, which we can point towards if anything breaks.

@frcroth frcroth requested a review from fm3 September 20, 2022 13:54
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frcroth frcroth merged commit 6bf7c18 into master Sep 20, 2022
@frcroth frcroth deleted the remove-zoomstep-parameter branch September 20, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove zoomStep entirely, after client has been updated
2 participants