Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Zarr Fixes #6422

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Small Zarr Fixes #6422

merged 2 commits into from
Aug 25, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 24, 2022

While working on S3 without credentials, I noticed two other zarr bugs that this PR addresses

  • the .array() call in the bytes converter is superfluous (copy paste relic), and for float datasets throws exceptions.
  • .zarray files with missing values could not be correctly parsed, due to missing WithDefaultValues

Steps to test:

  • I tested that I could now loat a float zarr dataset
  • I tested that reading remote zarr datasets with missing dimension_separator key in .zarray files works again
  • Needs datastore update after deployment
  • Ready for review

@fm3 fm3 requested a review from leowe August 24, 2022 14:58
@fm3 fm3 self-assigned this Aug 24, 2022
@fm3 fm3 mentioned this pull request Aug 25, 2022
Merged
3 tasks
leowe
leowe approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@leowe leowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@fm3 fm3 enabled auto-merge (squash) August 25, 2022 11:51
@fm3 fm3 merged commit c36ba0f into master Aug 25, 2022
@fm3 fm3 deleted the fix-zarr-float branch August 25, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leowe leowe leowe approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @leowe