Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds button for duplicating annotations #6386

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Aug 8, 2022

Steps to test:

  • Open an annotation (yours or from somebody else)
  • Open the menu next to "save", click duplicate
  • The current annotation will be saved, a duplicate will be created and you will be redirected to the duplicate

Issues:


(Please delete unneeded items, merge only when none are left open)

@normanrz normanrz self-assigned this Aug 8, 2022
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@normanrz
Copy link
Member Author

normanrz commented Aug 8, 2022

@philippotto Can you think of situations when we don't want to allow duplicating?

@philippotto
Copy link
Member

@philippotto Can you think of situations when we don't want to allow duplicating?

no, even if we would forbid it in certain circumstances, downloading+reuploading would be a workaround, anyway (which we don't forbid, either).

@normanrz
Copy link
Member Author

normanrz commented Aug 8, 2022

@philippotto Can you think of situations when we don't want to allow duplicating?

no, even if we would forbid it in certain circumstances, downloading+reuploading would be a workaround, anyway (which we don't forbid, either).

Well, there is an allowDownload restriction.

@fm3
Copy link
Member

fm3 commented Aug 8, 2022

allowDownload is currently always identical to allowAccess

@bulldozer-boy bulldozer-boy bot merged commit 5f5e4ba into master Aug 9, 2022
@bulldozer-boy bulldozer-boy bot deleted the duplicate-annotation branch August 9, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Duplicate of Annotation
3 participants