Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix closing of annotation share modal #6378

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix closing of annotation share modal #6378

merged 1 commit into from
Aug 5, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 5, 2022

URL of deployed dev instance (used for testing):

Steps to test:

  • close annotation share modal with X or ESC

Issues:

  • Ready for review

@fm3 fm3 requested a review from philippotto August 5, 2022 11:25
@fm3 fm3 self-assigned this Aug 5, 2022
philippotto
philippotto approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for doing this 👍

@fm3 fm3 enabled auto-merge (squash) August 5, 2022 11:26
@fm3 fm3 merged commit 7263187 into master Aug 5, 2022
@fm3 fm3 deleted the share-modal-close branch August 5, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't close "share" modal with X or Esc
2 participants
@fm3 @philippotto