Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zarr Segmentation Layer json parsing #6363

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 1, 2022

When parsing the datasource-properties.json, wk previously failed to recognize zarr segmentation layers. They were instead parsed as ZarrDataLayers (discarding segmentation-specific fields like largestSegmentId). The category field was still "segmentation" (creating an invalid state, and leading the frontend to in turn correctly show the layer as a segmentation). The symptom was that you could not create an annotation with this layer as fallback segmentation.

URL of deployed dev instance (used for testing):

Steps to test:

  • talk to me for a dataset with a zarr segmentation
  • load this dataset in your wk, refresh datasets with button in dashboard (as admin) or wait 1min for next scheduled refresh
  • create annotation for this dataset (segmentation as fallback is default)
  • should work, should be able to brush.

Issues:


@fm3 fm3 requested a review from leowe August 1, 2022 14:14
@fm3 fm3 self-assigned this Aug 1, 2022
Copy link
Contributor

@leowe leowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 merged commit b93e00e into master Aug 4, 2022
@fm3 fm3 deleted the fix-zarr-segmentation-parsing branch August 4, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create annotation with Zarr Segmentation as Fallback Layer
2 participants