Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "User access list" to Settings #6166

Merged
merged 8 commits into from
Apr 26, 2022
Merged

Move "User access list" to Settings #6166

merged 8 commits into from
Apr 26, 2022

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Apr 25, 2022 •
edited
Loading

PR does two little things:

  • move the "Users with Access" list form the main Dashboard->My Datasets (sub)-table to the the settings (under "Sharing Tab")
  • renamed all the react components used in the dataset settings view to reflect that:
    • all components are some tab
    • all components belong to the dataset settings view

URL of deployed dev instance (used for testing):

Steps to test:

  1. Navigate to Dashboard --> My Datasets
    • Table should no longer be expandable to show "Users with access"
  2. Go to Setting for a dataset --> "Sharing Tab"
  3. Expand "Users with access" panel.
  4. Tada

Issues:

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz changed the title User access list Move "User access list" to Settings Apr 25, 2022
@hotzenklotz hotzenklotz self-assigned this Apr 25, 2022
philippotto
philippotto approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great (and needed) clean up, too 👍

I'm wondering whether user might expect that the list "live updates" to changes which are not saved, yet? Maybe the text could clarify that this is not a preview? Not sure how, though, and maybe I'm overthinking this..

@hotzenklotz
Copy link
Member Author

I'm wondering whether user might expect that the list "live updates" to changes which are not saved, yet? Maybe the text could clarify that this is not a preview? Not sure how, though, and maybe I'm overthinking this..

I hadn't thought about that yet. Perhaps I add a little "i" icon with short description to clarify that.

@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into use…
73ef899 
…r_access_list

* 'master' of github.com:scalableminds/webknossos:
  In dataset upload, allow un-sorted anisotropic mags in properties.json (#6167)
@hotzenklotz
added info tooltip to user access list
0d0b042
@hotzenklotz
Copy link
Member Author

@philippotto How about:
image

@philippotto
Copy link
Member

@philippotto How about: image

👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) April 26, 2022 12:40
@hotzenklotz hotzenklotz merged commit 91a72b1 into master Apr 26, 2022
@hotzenklotz hotzenklotz deleted the user_access_list branch April 26, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@hotzenklotz hotzenklotz

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move dataset access list from dashboard to settings page
2 participants
@hotzenklotz @philippotto