Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make w shortcut non-looping #5865

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Make w shortcut non-looping #5865

merged 2 commits into from
Nov 25, 2021

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Nov 24, 2021

See the linked issues/reports.
While I was at it, I removed an old keyboard shortcut which allowed to cycle between tools using 1 but only if a volume tool was active. Very confusing and inferior to the w shortcut imo.

The toggling is a little bit weird, because the "Eraser" appears twice (once for brushing, once for tracing) and the one for tracing is hidden by default unless the "Trace" tool is active. However, that has been the case before as well.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Use w in an annotation to toggle through the tools. This should work reliably without jumping

Issues:


(Please delete unneded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Nov 24, 2021
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Works well 👍

@daniel-wer daniel-wer merged commit bc888f0 into master Nov 25, 2021
@daniel-wer daniel-wer deleted the w-non-looping branch November 25, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants