Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to fallback rendering (renderMissingDataBlack == false) #5862

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Default to fallback rendering (renderMissingDataBlack == false) #5862

merged 4 commits into from
Nov 23, 2021

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Nov 23, 2021 •
edited by daniel-wer
Loading

#5703 didn't work properly.

URL of deployed dev instance (used for testing):

Steps to test:

  • open dataset and ensure that rendermissingdatablack is false

Issues:

(Please delete unneded items, merge only when none are left open)

@philippotto philippotto self-assigned this Nov 23, 2021
daniel-wer
daniel-wer approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@philippotto philippotto merged commit 709a472 into master Nov 23, 2021
@philippotto philippotto deleted the default-to-fallback-rendering branch November 23, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer