Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy-buttons in context menu and change out-of-context-menu-click behavior #5658

Merged
merged 4 commits into from
Aug 10, 2021

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 6, 2021

With this PR:

  • the copy buttons in the context menu are fixed (before the PR, the blur() event was triggered directly and the menu was closed immediately)
  • clicking outside of the context menu closes it (and doesn't do anything else, such as creating a node)
  • the only downside: a repeated rightclick doesn't open the context menu again. technically, this should be possible, but the effort to implement this is several times higher than the current pr. Also, I think, it's not that important (right now, at least).

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open a tracing (disable classic mode)
  • open a context menu via right click
  • use the copy buttons (e.g., copy position) and ensure that the position is copied.
  • the context menu will stay open (I find that okay)
  • left click outside of the context menu --> the menu should close, but no node or similar should be created
  • right click outside of the context menu --> the menu should close and nothing else will happen. ideally, the context menu would open again, but as explained above, this "feature" got dropped with this PR for now.

Issues:


…ext menu only so that it closes the context menu (and doesn't do anything else)
@philippotto philippotto self-assigned this Aug 6, 2021
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well :)

@philippotto philippotto enabled auto-merge (squash) August 10, 2021 06:55
@philippotto philippotto merged commit dffed01 into master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants