Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve context menu and segment id handling #5637

Merged
merged 6 commits into from
Jul 27, 2021

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jul 26, 2021

  • always read the segment id from fallback data when necessary (also respect active mapping while doing so)
  • avoid empty context menus (these weren't opened previously, but this is also confusing when one expects a menu) by always showing "copy position" as a fallback.

URL of deployed dev instance (used for testing):

Steps to test:

  • open a dataset with segmentation layer in view mode and rightclick somewhere (disable classic controls): the menu should show an entry to copy the clicked position
  • load a dataset with a segmentation layer (should have multiple mags)
    • right click to copy a segment id before mag 1 was loaded --> the context menu should include an item to copy the segment id. before this pr, that entry only appeared when the segment id of the active mag was already loaded (i.e., fallback rendering was disabled)
  • repeat the last step, but with the cell picker tool. ensure that a segment id can be picked even when the best mag wasn't fully loaded yet

Issues:


@philippotto philippotto requested a review from daniel-wer July 26, 2021 12:32
@philippotto philippotto self-assigned this Jul 26, 2021
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philippotto philippotto merged commit 99cf736 into master Jul 27, 2021
@philippotto philippotto deleted the read-fallback-seg-id-for-context branch July 27, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants