Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default analytics uri #5607

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Add default analytics uri #5607

merged 4 commits into from
Jul 12, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 7, 2021 •
edited
Loading

  • Log back-end analytics events to the wk event relayer by default.
  • Empty key is no longer interpreted as opt-out, uri needs to be empty for that.

URL of deployed dev instance (used for testing):

Steps to test:

  • Logging should not show failed analytics requests
  • if backendAnalytics.verboseLogging = true, the log should show which events are sent
  • Specifying the environment variable DEV_WK_ANALYTICS_URI with emptystring (or adapting application.conf) should disable the analytics events.
  • The event relayer checks the api_key if your webKnossos instance claims to be one of the “known” instances.

@fm3 fm3 self-assigned this Jul 7, 2021
@fm3 fm3 changed the title [WIP] add default analytics uri Add default analytics uri Jul 8, 2021
@fm3 fm3 marked this pull request as ready for review July 8, 2021 09:08
@fm3 fm3 requested a review from normanrz July 8, 2021 09:10
@fm3 fm3 merged commit b741ea5 into master Jul 12, 2021
@fm3 fm3 deleted the analytics-default branch July 12, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@fm3 fm3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @normanrz