Skip to content

Omit parent release name from wk version string #5565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jun 14, 2021

The parent release as obtained by git describe --tags only yields the latest release if that tag happened in master. However, our release process means that often the tags do not land as direct ancestors to newer commits. Thus, this version string is often more confusing than helpful.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • visit api/buildinfo both locally and on dev deployment
  • should show "dev" or ci tag

@fm3 fm3 requested a review from philippotto June 14, 2021 06:13
@fm3 fm3 self-assigned this Jun 14, 2021
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fm3 fm3 merged commit 7c7a3dd into master Jun 14, 2021
@fm3 fm3 deleted the simplify-version branch June 14, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants