Fix desync of td view camera and store state #5550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug led to a distortion of the 3d viewport when moving/zooming after maximizing it (could happen after minimizing it as well). The cause of the bug was a desynchronization of the 3d view camera internal state and its store state. The 3d view camera was adjusted when maximizing the 3d viewport without updating the store state. This led to distortion errors, afterwards.
I scanned the code but didn't find other occurrences where the 3d view camera is updated without updating the store state.
URL of deployed dev instance (used for testing):
Steps to test:
.
Issues: