Fix creating/editing a volume task type #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
approved these changes
May 31, 2021
| } | ||
| {({ getFieldValue }) => ( | ||
| <div | ||
| style={{ |
There was a problem hiding this comment.
I'd propose to add a comment so that this doesn't happen again in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression which was introduced in 61d3bee. Even though, a volume task type doesn't really need settings, such as for soma clicking, the task type format still requires this (according to front-end as well as back-end types). In earlier versions, we simply hid the form fields but still maintained their values. I restored this behavior with this PR.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: