Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select components #5394

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Fix select components #5394

merged 4 commits into from
Apr 13, 2021

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 13, 2021 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • go to /tasks and type into the "User" select-input to see that the filtering works correctly

Issues:

@philippotto philippotto self-assigned this Apr 13, 2021
fm3
fm3 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :) 🎉

daniel-wer
daniel-wer approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment :)

frontend/javascripts/admin/task/task_list_view.js Outdated Show resolved Hide resolved
@philippotto philippotto merged commit 1213b70 into master Apr 13, 2021
@philippotto philippotto deleted the fix-select-ui branch April 13, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

@fm3 fm3 fm3 approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“No Data” in search field at Administration>>Tasks
3 participants
@philippotto @fm3 @daniel-wer