Fix rendering bug in oblique (and probably flight) mode #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
commented
Mar 17, 2021
Comment on lines
+131
to
+152
| let renderedLines = []; | ||
|
|
||
| window.addLine = (a: Vector3, b: Vector3) => { | ||
| const material = new THREE.LineBasicMaterial({ color: 0x0000ff }); | ||
|
|
||
| const points = []; | ||
| points.push(new THREE.Vector3(...a)); | ||
| points.push(new THREE.Vector3(...b)); | ||
|
|
||
| const geometry = new THREE.BufferGeometry().setFromPoints(points); | ||
|
|
||
| const line = new THREE.Line(geometry, material); | ||
| this.rootNode.add(line); | ||
| renderedLines.push(line); | ||
| }; | ||
|
|
||
| window.removeLines = () => { | ||
| for (const line of renderedLines) { | ||
| this.rootNode.remove(line); | ||
| } | ||
| renderedLines = []; | ||
| }; |
There was a problem hiding this comment.
I used that code to visualize the scan lines which the oblique bucket picker casts. Might be useful in the future, too, which is why I left it here (next to the debugging visualization of buckets).
There was a problem hiding this comment.
out-of-scope for this PR, but maybe it would makes sense to put these debug helpers in an object (e.g. window.__debug) to not clutter the window object?
There was a problem hiding this comment.
Good point. I created #5290
normanrz
approved these changes
Mar 17, 2021
Comment on lines
+131
to
+152
| let renderedLines = []; | ||
|
|
||
| window.addLine = (a: Vector3, b: Vector3) => { | ||
| const material = new THREE.LineBasicMaterial({ color: 0x0000ff }); | ||
|
|
||
| const points = []; | ||
| points.push(new THREE.Vector3(...a)); | ||
| points.push(new THREE.Vector3(...b)); | ||
|
|
||
| const geometry = new THREE.BufferGeometry().setFromPoints(points); | ||
|
|
||
| const line = new THREE.Line(geometry, material); | ||
| this.rootNode.add(line); | ||
| renderedLines.push(line); | ||
| }; | ||
|
|
||
| window.removeLines = () => { | ||
| for (const line of renderedLines) { | ||
| this.rootNode.remove(line); | ||
| } | ||
| renderedLines = []; | ||
| }; |
There was a problem hiding this comment.
out-of-scope for this PR, but maybe it would makes sense to put these debug helpers in an object (e.g. window.__debug) to not clutter the window object?
daniel-wer
reviewed
Mar 17, 2021
| @@ -23,6 +23,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released | |||
|
|
|||
| ### Fixed | |||
| - Fixed a regression in the task search which could lead to a frontend crash. [#5267](https://github.com/scalableminds/webknossos/pull/5267) | |||
| - Fixed a rendering bug in oblique mode. [#5267](https://github.com/scalableminds/webknossos/pull/5289) | |||
There was a problem hiding this comment.
Just noticed this, maybe you can slip it into another PR :)
Suggested change
| - Fixed a rendering bug in oblique mode. [#5267](https://github.com/scalableminds/webknossos/pull/5289) | |
| - Fixed a rendering bug in oblique mode. [#5289](https://github.com/scalableminds/webknossos/pull/5289) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: