Adapt Agglomerate Mapping Max Mag to correct value #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe it would already help a bit to add a comment to each of the constant definitions mentioning the other spot on which this depends? The other threshold also looks like it should be extracted to a constant (at least at the module level): https://github.com/scalableminds/webknossos/pull/4706/files#diff-279361122384dfd2a93e9f0ddaa2a847254e0d925ce220d63762f221c07d261cR58 |
|
Yes, god point :) I added comments, could you have another look? |
philippotto
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4706 increased the threshold from 8 to 16, so message should also appear only starting at 16.
Long-term it would be nice to have a single place for this value, but that is not trivial since the datastore config is not exposed to the frontend. We could instead add a flag to the data requests when this limit was exceeded or something. But for now I think this is ok.