Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow accessing dataset admin view configuration via sharing token #5164

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Allow accessing dataset admin view configuration via sharing token #5164

merged 2 commits into from
Feb 15, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 15, 2021 •
edited
Loading

Steps to test:

  • give a dataset an admin view configuration (e.g. layer configuration in settings view)
  • open private tab, open dataset there
  • should see the respective settings

Issues:

@fm3 fm3 self-assigned this Feb 15, 2021
@fm3 fm3 marked this pull request as ready for review February 15, 2021 13:42
@fm3 fm3 requested a review from philippotto February 15, 2021 13:42
philippotto
philippotto approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 added the automerge label Feb 15, 2021
@bulldozer-boy bulldozer-boy bot merged commit 1693719 into master Feb 15, 2021
@bulldozer-boy bulldozer-boy bot deleted the shared-dataset-settings branch February 15, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
automerge backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-public datasets accessed using a token do not honor default settings
2 participants
@fm3 @philippotto