Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Knossos cubes #5085

Merged
merged 11 commits into from
Feb 3, 2021
Merged

Drop support for Knossos cubes #5085

merged 11 commits into from
Feb 3, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 25, 2021 •
edited
Loading

As discussed previously, the Knossos dataformat support has not been tested in a while, and it never was 100% compatible anyway. Since all our datasets have by now been converted to wkw, the Knossos code can be removed.

I also added a few more type annotations to the datastore code.

Steps to test:

  • wkw datasets should still be reported + browsable

Issues:

@fm3 fm3 added the backend label Jan 25, 2021
@fm3 fm3 self-assigned this Jan 25, 2021
@fm3 fm3 changed the title [WIP] Drop support for Knossos cubes Drop support for Knossos cubes Jan 26, 2021
@fm3 fm3 marked this pull request as ready for review January 26, 2021 12:02
@fm3 fm3 requested a review from youri-k January 26, 2021 12:02
youri-k
youri-k approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that makes the code easier tor read 🎉

I just reviewed the code, so I did not test it yet. Do you think it's necessary before merging?
I'm pretty confident that this shouldn't cause any problems after reading the code.

One style question: Do we want to rename all Formats to jsonFormat in the future?

...nossos-datastore/app/com/scalableminds/webknossos/datastore/dataformats/BucketProvider.scala
)
}
result
implicit ec: ExecutionContext): Fox[Array[Byte]] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it a Fox[..]? I think the DataCubeCache can be rewrote to only use Box[..], but maybe that's another issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes could be right, but since this is not a change introduced here, I’d defer that. The Fox does not do any harm here for now :)

@fm3
Copy link
Member Author

fm3 commented Jan 26, 2021

Thanks for the quick review!
Yes, I think jsonFormat is a clearer name for these. Do you agree?
I already tested refreshing the dataset list and browsing the data, so I think we can say it’s fine without you re-testing. If the CI also agrees :)

@fm3 fm3 merged commit 6bceb22 into master Feb 3, 2021
@fm3 fm3 deleted the no-more-knossos-cubes branch February 3, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for knossos cubes
2 participants
@fm3 @youri-k