Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow handling dataset configurations for datasets not normally visible #5047

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Allow handling dataset configurations for datasets not normally visible #5047

merged 1 commit into from
Jan 14, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 13, 2021 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • create a second user not allowed to see a particular dataset
  • as orga admin, copy sharing link from dataset settings page, open as that second user
  • should be allowed to view and to change view settings in sidebar

Issues:

On Privacy

  • Privacy impact should be minimal, since dataset default view configurations do not contain any problematic information, and the requester needs to already know the dataset name (usually only happens when they received a sharing link anyway)

@fm3 fm3 self-assigned this Jan 13, 2021
@fm3 fm3 requested a review from youri-k January 13, 2021 09:58
youri-k
youri-k approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🎉

@fm3 fm3 merged commit 187a1b1 into master Jan 14, 2021
@fm3 fm3 deleted the dataset-conf-global branch January 14, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing dataset via token: saving dataSetConfiguration fails
2 participants
@fm3 @youri-k