Fix stack overflow in comments tab for trees with many comments #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bulldozer-boy merged 2 commits into master from fix-stackoverflow

Dec 2, 2020

Member

philippotto commented Dec 2, 2020

URL of deployed dev instance (used for testing):

https://___.webknossos.xyz

Steps to test:

open tracing with multiple comments (or create one first)
check that the comments are rendered properly

Issues:

fixes https://discuss.webknossos.org/t/crash-for-large-number-of-comments/1630/2

Updated (unreleased) changelog
Updated (unreleased) migration guide if applicable
Updated documentation if applicable
Adapted wk-connect if datastore API changes
Needs datastore update after deployment
Ready for review


          fix stack overflow in comments tab for trees with many comments

f0f64f3

philippotto requested a review from daniel-wer

December 2, 2020 15:00

philippotto self-assigned this


          update changelog

e250b32

daniel-wer approved these changes

View reviewed changes

Member

daniel-wer left a comment

LGTM 👍

philippotto added the automerge label

bulldozer-boy bot merged commit e099c57 into master

bulldozer-boy bot deleted the fix-stackoverflow branch

December 2, 2020 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels