Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat zero layer dataset as unusable #4959

Merged
merged 4 commits into from
Dec 3, 2020
Merged

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Nov 26, 2020

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • upload a zero layer dataset
  • should be marked as unusable in the frontend, but not throw an error

Issues:


@youri-k youri-k self-assigned this Nov 26, 2020
@youri-k youri-k requested a review from fm3 November 27, 2020 12:18
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also tried it and seems to work as expected :)

Does this interact with #4944 ? Will the scale still be available there for zero-layer datasets?

@youri-k
Copy link
Contributor Author

youri-k commented Dec 3, 2020

Yes, this does interact with #4944 and I will make the necessary changes there to make the scale still available.

@youri-k youri-k merged commit 5c330dc into master Dec 3, 2020
@fm3 fm3 deleted the zero-layer-dataset-unusable branch January 18, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider zero-layer datasets as inactive
2 participants