Organization restricted datastore #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 9, 2020 11:49
…anization-restricted-datastore
…anization-restricted-datastore
|
Changes thus far LGTM, but I think another change is required: datasets reported by that datastore should be ignored (probably with command line warning) if they are not for its organization |
fm3
requested changes
Oct 28, 2020
There was a problem hiding this comment.
Backend LGTM.
Sorry, one more concern: should the datastore be visible to users of other organizations? Maybe adapt the accessQuery? (Or if that causes trouble, at least hide it from the upload form dropdown menu? The refresh button should probably also not talk to datastores specific to other organizations)
fm3
approved these changes
Oct 28, 2020
added 2 commits
October 29, 2020 12:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
onlyAllowedOrganizationto random id => upload to that ds should failonlyAllowedOrganizationto organization id => upload to that ds should work when logged in as user of that orgIssues:
[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes