Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find data for volumes #4847

Merged
merged 8 commits into from
Oct 7, 2020
Merged

Find data for volumes #4847

merged 8 commits into from
Oct 7, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Oct 5, 2020

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open a volume tracing => find data button works and finds volume data
  • open an empty tracing with fallback layer => find data button looks for volumes first and checks fallback layer afterwards

Issues:

@youri-k youri-k self-assigned this Oct 5, 2020
fm3
fm3 requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! I added a comment concerning code duplication, otherwise this should be good to go :)

...ore/app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeTracingService.scala Outdated Show resolved Hide resolved
fm3
fm3 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

philippotto
philippotto requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature :) I added two suggestions for the front-end part 🦖

frontend/javascripts/oxalis/view/settings/dataset_settings_view.js Show resolved Hide resolved
frontend/javascripts/admin/admin_rest_api.js Outdated Show resolved Hide resolved
philippotto
philippotto approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@youri-k youri-k merged commit bb73244 into master Oct 7, 2020
@philippotto philippotto deleted the find-volume-data branch June 14, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

@fm3 fm3 fm3 approved these changes

Assignees

@youri-k youri-k

Labels
backend frontend hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“find data” for volume tracing layer
3 participants
@youri-k @fm3 @philippotto