Drag'n'drop hybrid import #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youri-k
commented
Sep 29, 2020
There was a problem hiding this comment.
Backend is ready for review.
The frontend works, but there are some code questions left. See my comments below @philippotto
fm3
reviewed
Sep 29, 2020
There was a problem hiding this comment.
Backend LGTM, I didn’t read the front-end code yet. A few thoughts to make sure everything works well:
- does the frontend get to know the increased version number after merging a tracing?
- is this route also called if there is no volume data? (i.e. skeleton only)
- does it handle empty data.zips gracefully?
- is dragging in a zipfile with multiple volume annotations also supported?
Yes, it updates the state internally after a successful response.
No, then only the skeleton updates are applied.
Yes.
No. |
Cool stuff!
Okay, let’s maybe create a follow-up issue for that then :) |
philippotto
requested changes
Sep 30, 2020
frontend/javascripts/oxalis/model/reducers/volumetracing_reducer_helpers.js
Show resolved
Hide resolved
|
I hope I addressed all of the feedback. Feel free to test again 🙂 |
added 2 commits
September 30, 2020 15:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes