Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty tree list and some tree list errors #4816

Merged
merged 5 commits into from
Sep 8, 2020

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Sep 8, 2020

  • Providing the width and height from the AutoSizer component explicitly as reactVirtualizedListProps to the SortableTree component solved the empty tree list for me. Seems like the SortableTree tried to figure those out itself otherwise which failed often. The library updates didn't help, but I kept them anyways.
  • I added two more errors from the SortableTree's drag-and-drop library to the ignored error list as they don't seem to have any serious effect but happen from time to time while drag-and-dropping 🤷‍♂️
  • I also fixed an error when multi-selecting trees and multi-selecting a group afterwards. (part of Support selecting multiple trees and a group #4789)

URL of deployed dev instance (used for testing):

Steps to test:

  • Open a tracing where the tree list is visible and reload a couple of times. The tree list should always be visible.
  • Multi-select some trees, then multi-select a group and click "Ok" -> There shouldn't be an error.

Issues:


Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Everything worked during testing 👍

@bulldozer-boy bulldozer-boy bot merged commit 93a5572 into master Sep 8, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-hidden-tree-list branch September 8, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree tab remains empty for some skeleton
2 participants