Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip glitch #4815

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Fix tooltip glitch #4815

merged 2 commits into from
Sep 8, 2020

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Sep 7, 2020

... by providing a key attribute. As far as I can see, React got confused and reused the same tooltip after the Edit button was clicked (to render the Save ... tooltip) which is why the tooltip stayed open, but was moved to the side. Therefore, the mouseleave or whatever other necessary event was not received. Providing a key solves this issue.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Click Edit annotation name in the annotation list, then click save or press enter -> The tooltip should be gone as expected.

Issues:


@daniel-wer daniel-wer added the bug label Sep 7, 2020
@daniel-wer daniel-wer self-assigned this Sep 7, 2020
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix :)

@daniel-wer daniel-wer merged commit 33b16b8 into master Sep 8, 2020
@daniel-wer daniel-wer deleted the fix-tooltip-glitch branch September 8, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI glitch: tooltips persist
2 participants