-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make decimal position input possible #4803
Conversation
I think currently the position is only adjusted to integers when refocusing and not on blur. That's why I did it the same way for now. If we want it, I could probably change it to update the display on blur. |
Works great!
Yes, that would be better, I think. Could you give it a try and change it so that it's adjusted to integer on blur? :) |
I think,you can change this in general for all adjustments of the position input. So, for example, when inputting an invalid position value, the value is only adjusted when refocusing, but this should also happen on blur. |
…knossos into decimal-position-input
Now the value is also adjusted on blur. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍 Please add a changelog entry before merging 📜
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Updated (unreleased) migration guide if applicableUpdated documentation if applicableAdapted wk-connect if datastore API changesNeeds datastore update after deployment