Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make decimal position input possible #4803

Merged
merged 9 commits into from
Oct 1, 2020
Merged

Conversation

grittaweisheit
Copy link
Contributor

@grittaweisheit grittaweisheit commented Aug 31, 2020

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open a dataset
  • paste a visibly different position with decimal places to the position input
  • the view should jump to that position
  • on refocusing on the input field the decimal places should vanish

Issues:


@grittaweisheit
Copy link
Contributor Author

I think currently the position is only adjusted to integers when refocusing and not on blur. That's why I did it the same way for now. If we want it, I could probably change it to update the display on blur.

@philippotto
Copy link
Member

Works great!

I think currently the position is only adjusted to integers when refocusing and not on blur. That's why I did it the same way for now. If we want it, I could probably change it to update the display on blur.

Yes, that would be better, I think. Could you give it a try and change it so that it's adjusted to integer on blur? :)

@philippotto
Copy link
Member

I think currently the position is only adjusted to integers when refocusing and not on blur

I think,you can change this in general for all adjustments of the position input. So, for example, when inputting an invalid position value, the value is only adjusted when refocusing, but this should also happen on blur.

@grittaweisheit
Copy link
Contributor Author

Now the value is also adjusted on blur.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 Please add a changelog entry before merging 📜

@grittaweisheit grittaweisheit merged commit c35ef6f into master Oct 1, 2020
@philippotto philippotto deleted the decimal-position-input branch June 14, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position input should accept floats
2 participants