Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of projects with a specific TaskType #4745

Merged
merged 14 commits into from
Aug 12, 2020

Conversation

grittaweisheit
Copy link
Contributor

@grittaweisheit grittaweisheit commented Jul 30, 2020

This PR adds the possibility to access a list of all projects that contain tasks with a specific taskType.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • go to the Task Types list view
  • click on "Projects" of a task type of your choosing
  • there should be a list of exactly those projects that contain a task of this type

Issues:


@grittaweisheit
Copy link
Contributor Author

Should I write documentation anywhere for this?

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!! Re-using the existing project view for this seems like a very good approach for this 👍

I'll test the branch when the CI build is ready.

Regarding the back-end code, I cannot say much. @fm3 The changes are probably fine for you, right?

frontend/javascripts/admin/project/project_list_view.js Outdated Show resolved Hide resolved
frontend/javascripts/admin/project/project_list_view.js Outdated Show resolved Hide resolved
@philippotto
Copy link
Member

Should I write documentation anywhere for this?

I think, that's not necessary, as the feature is quite self-explanatory.

@philippotto
Copy link
Member

I just tried to test this branch, but got an SQL error when trying to create a new task. But I don't think this is related to this PR (?). @fm3 Do you know what's going on?

See screenshot:
image

@fm3
Copy link
Member

fm3 commented Aug 5, 2020

@philippotto thanks for pointing this out, that is in fact an independent bug introduced in #4711. I added a commit here that fixes it.

Also, backend LGTM.

@grittaweisheit I noticed that when navigating away via menu from this task-type specific project page to the main project page, the content does not seem to be updated, including the title. That’s probably a react problem?

@grittaweisheit
Copy link
Contributor Author

@fm3 Yes, it was a react problem; thanks for pointing that out! The component didn't update properly when the props changed. It works now :)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works very well 👍

@grittaweisheit grittaweisheit merged commit 823021c into master Aug 12, 2020
@fm3 fm3 deleted the list-task-types-projects branch January 18, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to list projects which use a specific task type
3 participants