-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List of projects with a specific TaskType #4745
Conversation
Should I write documentation anywhere for this? |
…ebknossos into list-task-types-projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!! Re-using the existing project view for this seems like a very good approach for this 👍
I'll test the branch when the CI build is ready.
Regarding the back-end code, I cannot say much. @fm3 The changes are probably fine for you, right?
I think, that's not necessary, as the feature is quite self-explanatory. |
I just tried to test this branch, but got an SQL error when trying to create a new task. But I don't think this is related to this PR (?). @fm3 Do you know what's going on? |
@philippotto thanks for pointing this out, that is in fact an independent bug introduced in #4711. I added a commit here that fixes it. Also, backend LGTM. @grittaweisheit I noticed that when navigating away via menu from this task-type specific project page to the main project page, the content does not seem to be updated, including the title. That’s probably a react problem? |
@fm3 Yes, it was a react problem; thanks for pointing that out! The component didn't update properly when the props changed. It works now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Works very well 👍
This PR adds the possibility to access a list of all projects that contain tasks with a specific taskType.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Updated (unreleased) migration guide if applicableUpdated documentation if applicableAdapted wk-connect if datastore API changesNeeds datastore update after deployment