Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix groups in multicomponent tree splitter #4735

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Fix groups in multicomponent tree splitter #4735

merged 4 commits into from
Jul 30, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 27, 2020 •
edited
Loading

When uploading an NML with multiple trees that each have multiple components, the wrapping tree groups did not get added properly (always using the original passed treeGroups as base again, instead of the previously mutated variable).

Steps to test:

  • upload NML with multiple trees/“things” that (1) already have groups (2) are have multiple components
  • should not give an error, instead import those and split the trees as expected

Issues:

@fm3 fm3 changed the title Fix groups in multicomponent tree splitter Fix groups in multicomponent tree splitter Jul 27, 2020
@fm3 fm3 self-assigned this Jul 27, 2020
@fm3 fm3 marked this pull request as ready for review July 27, 2020 12:20
@fm3 fm3 requested a review from youri-k July 27, 2020 12:21
youri-k
youri-k approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit 51801d4 into master Jul 30, 2020
@fm3 fm3 deleted the fix-multicomponent-split branch July 30, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tree group IDs get screwed up when splitting multicomponent-trees
2 participants
@fm3 @youri-k