Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make organization name unique #4685

Merged
merged 5 commits into from
Jun 29, 2020
Merged

Make organization name unique #4685

merged 5 commits into from
Jun 29, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jun 24, 2020 •
edited
Loading

Introducing a UNIQUE constraint to organization names, to avoid wrong lookups.

Steps to test:

  • change to a demo instance via application.conf (isDemoInstance=true)
  • change L45 in spotlight_registration_form.js to a fixed string
  • error message should show, should not be able to create multiple organizations with the same name
  • creating organizations with different names should still be possible

Issues:

@fm3 fm3 added the backend label Jun 24, 2020
@fm3 fm3 self-assigned this Jun 24, 2020
@fm3 fm3 requested a review from youri-k June 24, 2020 08:09
youri-k
youri-k approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 added the automerge label Jun 29, 2020
@bulldozer-boy bulldozer-boy bot merged commit 15d92c4 into master Jun 29, 2020
@bulldozer-boy bulldozer-boy bot deleted the organization-name-unique branch June 29, 2020 08:47
@fm3 fm3 mentioned this pull request Jul 8, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
automerge backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent duplicate organization names
2 participants
@fm3 @youri-k