-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove task column from bulk task creation #4629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this 🤟 I know, that this change has been announced now, but nevertheless, I think it would be good to show a helpful error message in case somebody pastes/uplads an invalid CSV. I'm not sure what happens right now, but I think, that the error is not caught (at all?).
I think, a simple try/catch in the submit
method would be quite helpful. The catch clause could show an alert saying something like "The CSV could not be parsed correctly. Please doublecheck that the CSV data matches the required format. Also note that the obsolete Teams
column is not supported, anymore, and might need to be removed in your CSV data."
Not too sure about the last sentence, since it's very specific (and will get obsolete on its own), but I think, this will likely save some trouble for multiple people (also for other labs). In a month, we could remove the sentence about the teams-column again. What do you think?
Good point :) I added an explaining note to the error message and created issue #4633 so that it does not remain there indefinitely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍
This time we gave some heads-up about this change. Redoing the front-end changes of #2553
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment