Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove task column from bulk task creation #4629

Merged
merged 5 commits into from
Jun 1, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 27, 2020

This time we gave some heads-up about this change. Redoing the front-end changes of #2553

URL of deployed dev instance (used for testing):

Steps to test:

  • create some tasks via csv or via bulk form

Issues:


@fm3 fm3 self-assigned this May 27, 2020
@fm3 fm3 requested a review from philippotto May 27, 2020 13:52
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this 🤟 I know, that this change has been announced now, but nevertheless, I think it would be good to show a helpful error message in case somebody pastes/uplads an invalid CSV. I'm not sure what happens right now, but I think, that the error is not caught (at all?).

I think, a simple try/catch in the submit method would be quite helpful. The catch clause could show an alert saying something like "The CSV could not be parsed correctly. Please doublecheck that the CSV data matches the required format. Also note that the obsolete Teams column is not supported, anymore, and might need to be removed in your CSV data."

Not too sure about the last sentence, since it's very specific (and will get obsolete on its own), but I think, this will likely save some trouble for multiple people (also for other labs). In a month, we could remove the sentence about the teams-column again. What do you think?

@fm3
Copy link
Member Author

fm3 commented May 28, 2020

Good point :) I added an explaining note to the error message and created issue #4633 so that it does not remain there indefinitely

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@fm3 fm3 added the automerge label Jun 1, 2020
@bulldozer-boy bulldozer-boy bot merged commit ca1e3d3 into master Jun 1, 2020
@bulldozer-boy bulldozer-boy bot deleted the remove-team-from-bulk-csv branch June 1, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove team column from bulk task creation csv
2 participants