Don't render ActionBarView during loading #4612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
commented
May 12, 2020
There was a problem hiding this comment.
@daniel-wer I recommend to enable the Hide whitespace changes setting in github.
| @@ -287,8 +287,8 @@ class DatasetInfoTabView extends React.PureComponent<Props> { | |||
|
|
|||
| return ( | |||
| <div className="flex-overflow"> | |||
| <p>{annotationTypeLabel}</p> | |||
There was a problem hiding this comment.
This produced a warning because p tags shouldn't contain divs.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kills two birds with one stone: The action bar view doesn't show incorrect data during loading anymore (e.g., invalid position). Additionally, the sharing modals are not instantiated before loading which avoids trying to load sharing tokens for the dummy dataset which the store holds initially (which always fails).
URL of deployed dev instance (used for testing):
Steps to test:
Issues: