-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finer control over interval range in timetracking view #4604
Conversation
@@ -300,6 +300,7 @@ class TimeLineView extends React.PureComponent<Props, State> { | |||
</FormItem> | |||
<FormItem {...formItemLayout} label="Date"> | |||
<RangePicker | |||
showTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose to disable the minutes or at least the seconds if that makes the ui less complicated. According to the antd docs you can supply an object to showTime
which will be passed on to the TimePicker component (https://ant.design/components/time-picker/#API). Does that work for our antd version and if so does it make the UI simpler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly the less complicated version seems not to be available in our antd version. We would need to upgrade antd for this. On the newest node version the RangePicker
could look like this.
I choose to keep the option to select minutes and removed only the seconds as the selection of minutes gives the possibility for detailed insight into the tracked time of users.
Additionally only having hours looks pretty awful in our antd version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for investigating. I would propose to merge this as-is and benefit from the better UI once we decide to upgrade antd in the future 👍
This PR adds a finer control to the time interval in the timetracking view.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated (unreleased) migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment