Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration for setups with one organization #4559

Merged
merged 7 commits into from
Apr 21, 2020
Merged

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 21, 2020

This PR removes the (mainly superfluous) defaultOrganization config from application.conf and instead makes sure that getDefaultOrganization is used where it makes sense.

I think, there is further potential for clean up. I'll create another issue for that.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • test registration in the following scenarios:
    • isDemoInstance is true
    • isDemoInstance is false (only one organization should be present)

Issues:


@philippotto philippotto self-assigned this Apr 21, 2020
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 🎉 Thanks for the quick yet clean fix :)

@bulldozer-boy bulldozer-boy bot merged commit 945d902 into master Apr 21, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-register branch April 21, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing up for default organization is broken
2 participants