Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group sorting when there are no trees #4542

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Fix group sorting when there are no trees #4542

merged 3 commits into from
Apr 14, 2020

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Apr 9, 2020 •
edited by philippotto
Loading

Group sorting by name didn't work when there were no trees in this nesting level.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Create a tracing and only create groups. The groups should be sorted as expected.

Issues:

@daniel-wer daniel-wer added the bug label Apr 9, 2020
@daniel-wer daniel-wer self-assigned this Apr 9, 2020
philippotto
philippotto approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bulldozer-boy bulldozer-boy bot merged commit fbc6505 into master Apr 14, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-group-sorting branch April 14, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@daniel-wer daniel-wer

Labels
automerge bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting in tree tab should also sort tree groups by name
2 participants
@daniel-wer @philippotto