Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mappings field in datasource optional #4532

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Make mappings field in datasource optional #4532

merged 4 commits into from
Apr 9, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 7, 2020 •
edited
Loading

Mappings field is not used by wk itself anymore. to preserve backwards compatibility, this PR makes it optional, rather than removing it entirely.

URL of deployed dev instance (used for testing):

Steps to test:

  • Remove mappings attribute from a segmentation layer in datasource-properties.json
  • wk should still serve the dataset, mappings should still work
  • edit page should work without error message, changing bbox and saving should still work

Issues:

  • Updated changelog
  • Needs datastore update after deployment
  • Ready for review

@fm3 fm3 self-assigned this Apr 7, 2020
@fm3 fm3 changed the title [WIP] Make mappings field in datasource optional Make mappings field in datasource optional Apr 7, 2020
@fm3 fm3 added the backend label Apr 7, 2020
@fm3 fm3 marked this pull request as ready for review April 7, 2020 13:47
@fm3 fm3 requested a review from youri-k April 7, 2020 13:47
youri-k
youri-k approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Did not test it though

@fm3 fm3 merged commit b119728 into master Apr 9, 2020
@fm3 fm3 deleted the mappings-optional branch April 9, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WK datastore should not require "mapping" parameter
2 participants
@fm3 @youri-k