Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no modal for empty tree-group deletion #4506

Merged
merged 4 commits into from
Mar 30, 2020
Merged

no modal for empty tree-group deletion #4506

merged 4 commits into from
Mar 30, 2020

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Mar 30, 2020

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • delete empty tree group => should just work
  • delete non-empty tree group => should still ask for confirmation

Issues:

@youri-k youri-k self-assigned this Mar 30, 2020
philippotto
philippotto approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

frontend/javascripts/oxalis/view/right-menu/trees_tab_view.js Show resolved Hide resolved
@youri-k
Copy link
Contributor Author

youri-k commented Mar 30, 2020

Ok perfect 🙂

@youri-k youri-k merged commit 628a6e3 into master Mar 30, 2020
@philippotto philippotto deleted the easy-delete-empty-tree-group branch June 14, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

@MichaelBuessemeyer MichaelBuessemeyer Awaiting requested review from MichaelBuessemeyer

Assignees

@youri-k youri-k

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting empty tree group should not prompt confirmation message
2 participants
@youri-k @philippotto